AddWatchersOnCorrespond - Revision history

Robl: BUGFIX: add CreatorEmailAddr as lower case. Check for bounce addresses lower case.

2023-05-03T11:47:08Z

BUGFIX: add CreatorEmailAddr as lower case. Check for bounce addresses lower case.

← Older revision		Revision as of 07:47, 3 May 2023
Line 14:		Line 14:

	2022-12-06: Populate RealName from email header when creating new user. (RT inserts the user's email address in the "phrase" part of the From: header if RealName is empty. This fix prevents emails bouncing because a mail provider's anti-spoofing policy rejects mail with an email address in the "phrase" section of From:/Cc: headers. )		2022-12-06: Populate RealName from email header when creating new user. (RT inserts the user's email address in the "phrase" part of the From: header if RealName is empty. This fix prevents emails bouncing because a mail provider's anti-spoofing policy rejects mail with an email address in the "phrase" section of From:/Cc: headers. )

			2023-05-03: (RobL) BUGFIX: add CreatorEmailAddr as lower case. Check for bounce addresses lower case.

	----		----
Line 46:		Line 48:
	# - including the transaction creator, and if it is an email, the sender and recipients of that email		# - including the transaction creator, and if it is an email, the sender and recipients of that email
	my %People;		my %People;
	my $CreatorEmailAddr = $self->TransactionObj->CreatorObj->EmailAddress;		my $CreatorEmailAddr = lc $self->TransactionObj->CreatorObj->EmailAddress;
	my $CreatorRealName = $self->TransactionObj->CreatorObj->RealName;		my $CreatorRealName = $self->TransactionObj->CreatorObj->RealName;
	$People{$CreatorEmailAddr}{RealName} = GetFullName($CreatorEmailAddr,$CreatorRealName);		$People{$CreatorEmailAddr}{RealName} = GetFullName($CreatorEmailAddr,$CreatorRealName);
Line 76:		Line 78:
	foreach my $addr (sort keys %People) {		foreach my $addr (sort keys %People) {

	next if ($addr =~ /^(postmaster\|root\|~~Mailer~~-~~Daemon~~)\@/);		next if ($addr =~ /^(postmaster\|root\|mailer-daemon)\@/);

	my $User = RT::User->new( $RT::SystemUser );		my $User = RT::User->new( $RT::SystemUser );

Robl: add category

2022-12-16T10:33:08Z

add category

← Older revision		Revision as of 06:33, 16 December 2022
Line 135:		Line 135:

	----		----
			[[Category:RT Action]]

Robl: link to AddWatchersOnCorrespondDomains

2022-12-07T17:47:26Z

link to AddWatchersOnCorrespondDomains

← Older revision		Revision as of 13:47, 7 December 2022
Line 6:		Line 6:

	I wrote this [[Scrip]] to replace the patch we used to make to the RT Email Interface code, called [[ParseFollowupMessageForTicketCcs]]. Accordingly, it carries the same security warning about allowing basically '''anyone''' to add themselves to '''any''' ticket, simply by sending an appropriately formatted email. Some RT sites might not want this behaviour, but it is necessary for us.		I wrote this [[Scrip]] to replace the patch we used to make to the RT Email Interface code, called [[ParseFollowupMessageForTicketCcs]]. Accordingly, it carries the same security warning about allowing basically '''anyone''' to add themselves to '''any''' ticket, simply by sending an appropriately formatted email. Some RT sites might not want this behaviour, but it is necessary for us.

			* [[AddWatchersOnCorrespondDomains]] is a modified version of this Scrip which is more restrictive by domain.

	Changelog		Changelog

Robl: remove unused $phrase variable.

2022-12-07T15:40:04Z

remove unused $phrase variable.

← Older revision		Revision as of 11:40, 7 December 2022
Line 61:		Line 61:
	# Get phrase from address header for full name: "Fred Bloggs" <fred@example.com>		# Get phrase from address header for full name: "Fred Bloggs" <fred@example.com>
	# (Extract Fred Bloggs to fullname.) Clean up. If nothing suitable then make something from email.		# (Extract Fred Bloggs to fullname.) Clean up. If nothing suitable then make something from email.
	~~my $phrase = $addrobj->phrase;~~
	my $fullname = GetFullName($addr,$addrobj->phrase);		my $fullname = GetFullName($addr,$addrobj->phrase);
	$People{$addr}{RealName} = $fullname;		$People{$addr}{RealName} = $fullname;

Robl: update sort

2022-12-07T09:29:13Z

update sort

← Older revision		Revision as of 05:29, 7 December 2022
Line 73:		Line 73:

	# Now check if each user is already watching the ticket or queue:		# Now check if each user is already watching the ticket or queue:
	foreach my $addr (sort ~~{ $a <=> $b }~~ keys %People) {		foreach my $addr (sort keys %People) {

	next if ($addr =~ /^(postmaster\|root\|Mailer-Daemon)\@/);		next if ($addr =~ /^(postmaster\|root\|Mailer-Daemon)\@/);

Robl: tweaks

2022-12-06T15:27:57Z

tweaks

← Older revision		Revision as of 11:27, 6 December 2022
Line 10:		Line 10:

	2012-01-01: Fixed a bug in which the owner of the ticket would have been added as a Cc: for every reply he made. (HaimDimer)		2012-01-01: Fixed a bug in which the owner of the ticket would have been added as a Cc: for every reply he made. (HaimDimer)
	2022-12-06: Populate ~~for~~ RealName from email header when creating new user. (RT inserts the user's email address in the "phrase" part of the header if RealName is empty. This prevents emails bouncing ~~where~~ mail provider's anti-spoofing policy rejects mail ~~where~~ email address is in the "phrase" section of From:/Cc: headers. )
			2022-12-06: Populate RealName from email header when creating new user. (RT inserts the user's email address in the "phrase" part of the From: header if RealName is empty. This fix prevents emails bouncing because a mail provider's anti-spoofing policy rejects mail with an email address in the "phrase" section of From:/Cc: headers. )

	----		----

Robl: Populate RealName from email header or always ensure RealName is set for newly created users.

2022-12-06T15:25:53Z

Populate RealName from email header or always ensure RealName is set for newly created users.

← Older revision		Revision as of 11:25, 6 December 2022
Line 5:		Line 5:
	In our RT setup, we have a group named '''general''' which contains all admins for our site. If the user this [[Scrip]] is going to add as a [[Watcher]] to the ticket is also a member of the '''general''' group, then the Scrip will add them as an [[AdminCC]] [[Watcher]] instead of a [[CC]] [[Watcher]]. It should be fairly easy for others who do not need this feature to remove or modify this [[Scrip]] accordingly.		In our RT setup, we have a group named '''general''' which contains all admins for our site. If the user this [[Scrip]] is going to add as a [[Watcher]] to the ticket is also a member of the '''general''' group, then the Scrip will add them as an [[AdminCC]] [[Watcher]] instead of a [[CC]] [[Watcher]]. It should be fairly easy for others who do not need this feature to remove or modify this [[Scrip]] accordingly.

	I wrote this [[Scrip]] to replace the patch we used to make to the RT Email Interface code, called [[ParseFollowupMessageForTicketCcs]]. Accordingly, it carries the same security warning about allowing basically '''anyone''' to add themselves to '''any''' ticket, simply by sending an appropriately formatted email. Some RT sites might not want this ~~behavior~~, but it is necessary for us.		I wrote this [[Scrip]] to replace the patch we used to make to the RT Email Interface code, called [[ParseFollowupMessageForTicketCcs]]. Accordingly, it carries the same security warning about allowing basically '''anyone''' to add themselves to '''any''' ticket, simply by sending an appropriately formatted email. Some RT sites might not want this behaviour, but it is necessary for us.

	Changelog		Changelog

	2012-01-01: Fixed a bug in which the owner of the ticket would have been added as a Cc: for every reply he made. (HaimDimer)		2012-01-01: Fixed a bug in which the owner of the ticket would have been added as a Cc: for every reply he made. (HaimDimer)
			2022-12-06: Populate for RealName from email header when creating new user. (RT inserts the user's email address in the "phrase" part of the header if RealName is empty. This prevents emails bouncing where mail provider's anti-spoofing policy rejects mail where email address is in the "phrase" section of From:/Cc: headers. )

	----		----
Line 41:		Line 42:
	# Extract a list of people associated with this transaction:		# Extract a list of people associated with this transaction:
	# - including the transaction creator, and if it is an email, the sender and recipients of that email		# - including the transaction creator, and if it is an email, the sender and recipients of that email
	my @People = ($~~EmailAddr~~);		my %People;
			my $CreatorEmailAddr = $self->TransactionObj->CreatorObj->EmailAddress;
			my $CreatorRealName = $self->TransactionObj->CreatorObj->RealName;
			$People{$CreatorEmailAddr}{RealName} = GetFullName($CreatorEmailAddr,$CreatorRealName);

	foreach my $h (qw(From To Cc)) {		foreach my $h (qw(From To Cc)) {
	my $header = $Transaction->Attachments->First->GetHeader($h);		my $header = $Transaction->Attachments->First->GetHeader($h);
Line 52:		Line 57:
	# Ignore any email address that looks like one for ANY of our queues:		# Ignore any email address that looks like one for ANY of our queues:
	next if RT::EmailParser->IsRTAddress($addr);		next if RT::EmailParser->IsRTAddress($addr);
	$RT::Logger->debug("$scrip: Ticket #$Id correspondence contains header - $h: $addr");
	~~push @People, $addr~~;		# Get phrase from address header for full name: "Fred Bloggs" <fred@example.com>
			# (Extract Fred Bloggs to fullname.) Clean up. If nothing suitable then make something from email.
			my $phrase = $addrobj->phrase;
			my $fullname = GetFullName($addr,$addrobj->phrase);
			$People{$addr}{RealName} = $fullname;
			$RT::Logger->debug("$scrip: Ticket #$Id correspondence contains header - $h: $addr $fullname");
	}		}
	}		}
Line 62:		Line 72:

	# Now check if each user is already watching the ticket or queue:		# Now check if each user is already watching the ticket or queue:
	foreach my $addr (@People) {		foreach my $addr (sort { $a <=> $b } keys %People) {
	my $User = RT::User->new($RT::SystemUser);
	$User->LoadOrCreateByEmail($addr);		next if ($addr =~ /^(postmaster\|root\|Mailer-Daemon)\@/);

			my $User = RT::User->new( $RT::SystemUser );
			$User->LoadOrCreateByEmail(
			RealName => $People{$addr}{RealName},
			EmailAddress => $addr,
			Comments => "Autocreated by $scrip",
			);

	my $Name = $User->Name;		my $Name = $User->Name;
	my $Principal = $User->PrincipalId;		my $Principal = $User->PrincipalId;
Line 73:		Line 91:
	$Ticket->IsWatcher(Type => 'Requestor', PrincipalId => $Principal) or		$Ticket->IsWatcher(Type => 'Requestor', PrincipalId => $Principal) or
	$Ticket->IsOwner($User) )) {		$Ticket->IsOwner($User) )) {
	# If the user is a member of the experts group, then add them as an AdminCc, otherwise as a ~~nor~~		# If the user is a member of the experts group, then add them as an AdminCc, otherwise as a Cc:
	my $type = 'Cc';		my $type = 'Cc';
	$type = 'AdminCc' if $Experts->HasMember($User->PrincipalObj);		$type = 'AdminCc' if $Experts->HasMember($User->PrincipalObj);
Line 79:		Line 97:
	my ($ret, $msg) = $Ticket->AddWatcher(Type => $type, PrincipalId => $Principal);		my ($ret, $msg) = $Ticket->AddWatcher(Type => $type, PrincipalId => $Principal);
	if ($ret) {		if ($ret) {
	$RT::Logger->info("$scrip: New $type watcher added to ticket #$Id: $addr (#$Principal)");		$RT::Logger->info("$scrip: New $type watcher added to ticket #$Id: $addr $fullname (#$Principal)");
	} else {		} else {
	$RT::Logger->error("$scrip: Failed to add new $type watcher to ticket #$Id: $addr (#$Principal) - $msg");		$RT::Logger->error("$scrip: Failed to add new $type watcher to ticket #$Id: $addr (#$Principal) - $msg");
	}		}
	}		}
			}

			sub GetFullName {

			# Get a nicely formatted name for RT RealName Field:

			# If fullname is blank, make something up from the
			# local_part of the email address: "fred.bloggs@..." -> "Fred Bloggs".
			# Do not allow fullname to contain "@".

			my ($addr,$fullname) = @_;
			my ($local_part,$domain) = split('@', $addr);

			if (($fullname eq '') \|\| ($fullname =~ /\@/)) {
			$fullname = $local_part;
			$fullname =~ s/[\._-]/ /g;
			$fullname =~ s/(\w+)/\u$1/g;
			}

			$fullname =~ s/^[\"\']\|[\"\']$//g; # strip leading/trailing " or '
			$fullname =~ s/^\s+\|\s+$//g; # strip leading/trailing spaces

			return $fullname;
	}		}

Cure: Fix truncated line in scrip

2016-11-04T14:13:09Z

Fix truncated line in scrip

← Older revision		Revision as of 10:13, 4 November 2016
Line 81:		Line 81:
	$RT::Logger->info("$scrip: New $type watcher added to ticket #$Id: $addr (#$Principal)");		$RT::Logger->info("$scrip: New $type watcher added to ticket #$Id: $addr (#$Principal)");
	} else {		} else {
	$RT::Logger->error("$scrip: Failed to add new $type watcher to ticket #$Id: $addr (#$~~Princi~~		$RT::Logger->error("$scrip: Failed to add new $type watcher to ticket #$Id: $addr (#$Principal) - $msg");
	}		}
	}		}

Tharn at 23:23, 13 August 2016

2016-08-13T23:23:54Z

Tharn at 23:22, 13 August 2016

2016-08-13T23:22:00Z

← Older revision		Revision as of 19:22, 13 August 2016
Line 30:		Line 30:

	----		----
			<pre>
	# Get some info:		# Get some info:
	my $scrip = 'Scrip:AddWatchersOnCorrespond';		my $scrip = 'Scrip:AddWatchersOnCorrespond';
Line 87:		Line 87:

	return 1;		return 1;
			</pre>

	# vim:ft=perl:		# vim:ft=perl:

	----		----

← Older revision		Revision as of 19:23, 13 August 2016
Line 31:		Line 31:
	----		----
	<pre>		<pre>
	# Get some info:		# Get some info:
	my $scrip = 'Scrip:AddWatchersOnCorrespond';		my $scrip = 'Scrip:AddWatchersOnCorrespond';
	my $Transaction = $self->TransactionObj;		my $Transaction = $self->TransactionObj;
	my $EmailAddr = $self->TransactionObj->CreatorObj->EmailAddress;		my $EmailAddr = $self->TransactionObj->CreatorObj->EmailAddress;
	my $Queue = $self->TicketObj->QueueObj;		my $Queue = $self->TicketObj->QueueObj;
	my $Ticket = $self->TicketObj;		my $Ticket = $self->TicketObj;
	my $Id = $self->TicketObj->id;		my $Id = $self->TicketObj->id;

	# Extract a list of people associated with this transaction:		# Extract a list of people associated with this transaction:
	# - including the transaction creator, and if it is an email, the sender and recipients of that email ~~message.~~		# - including the transaction creator, and if it is an email, the sender and recipients of that email
	my @People = ($EmailAddr);		my @People = ($EmailAddr);
	foreach my $h (qw(From To Cc)) {		foreach my $h (qw(From To Cc)) {
	my $header = $Transaction->Attachments->First->GetHeader($h);		my $header = $Transaction->Attachments->First->GetHeader($h);
	my @addr = Mail::Address->parse($header);		my @addr = Mail::Address->parse($header);
	foreach my $addrobj (@addr) {		foreach my $addrobj (@addr) {
	my $addr = lc $RT::Nobody->UserObj->CanonicalizeEmailAddress($addrobj->address);		my $addr = lc $RT::Nobody->UserObj->CanonicalizeEmailAddress($addrobj->address);
	# Ignore the specific addresses for this queue:		# Ignore the specific addresses for this queue:
	next if lc $Queue->CorrespondAddress eq $addr;		next if lc $Queue->CorrespondAddress eq $addr;
	next if lc $Queue->CommentAddress eq $addr;		next if lc $Queue->CommentAddress eq $addr;
	# Ignore any email address that looks like one for ANY of our queues:		# Ignore any email address that looks like one for ANY of our queues:
	next if RT::EmailParser->IsRTAddress($addr);		next if RT::EmailParser->IsRTAddress($addr);
	$RT::Logger->debug("$scrip: Ticket #$Id correspondence contains header - $h: $addr");		$RT::Logger->debug("$scrip: Ticket #$Id correspondence contains header - $h: $addr");
	push @People, $addr;		push @People, $addr;
	}		}
	}		}

	# Lookup the 'experts' (general) group to use below:		# Lookup the 'experts' (general) group to use below:
	my $Experts = RT::Group->new($self->CurrentUser);		my $Experts = RT::Group->new($self->CurrentUser);
	$Experts->LoadUserDefinedGroup('general');		$Experts->LoadUserDefinedGroup('general');

	# Now check if each user is already watching the ticket or queue:		# Now check if each user is already watching the ticket or queue:
	foreach my $addr (@People) {		foreach my $addr (@People) {
	my $User = RT::User->new($RT::SystemUser);		my $User = RT::User->new($RT::SystemUser);
	$User->LoadOrCreateByEmail($addr);		$User->LoadOrCreateByEmail($addr);
	my $Name = $User->Name;		my $Name = $User->Name;
	my $Principal = $User->PrincipalId;		my $Principal = $User->PrincipalId;
	if ( not ($Queue->IsWatcher(Type => 'Cc', PrincipalId => $Principal) or		if ( not ($Queue->IsWatcher(Type => 'Cc', PrincipalId => $Principal) or
	$Queue->IsWatcher(Type => 'AdminCc', PrincipalId => $Principal) or		$Queue->IsWatcher(Type => 'AdminCc', PrincipalId => $Principal) or
	$Ticket->IsWatcher(Type => 'Cc', PrincipalId => $Principal) or		$Ticket->IsWatcher(Type => 'Cc', PrincipalId => $Principal) or
	$Ticket->IsWatcher(Type => 'AdminCc', PrincipalId => $Principal) or		$Ticket->IsWatcher(Type => 'AdminCc', PrincipalId => $Principal) or
	$Ticket->IsWatcher(Type => 'Requestor', PrincipalId => $Principal) or		$Ticket->IsWatcher(Type => 'Requestor', PrincipalId => $Principal) or
	$Ticket->IsOwner($User) )) {		$Ticket->IsOwner($User) )) {
	# If the user is a member of the experts group, then add them as an AdminCc, otherwise as a ~~normal Cc:~~		# If the user is a member of the experts group, then add them as an AdminCc, otherwise as a nor
	my $type = 'Cc';		my $type = 'Cc';
	$type = 'AdminCc' if $Experts->HasMember($User->PrincipalObj);		$type = 'AdminCc' if $Experts->HasMember($User->PrincipalObj);
	# Add the new watcher now and check for errors:		# Add the new watcher now and check for errors:
	my ($ret, $msg) = $Ticket->AddWatcher(Type => $type, PrincipalId => $Principal);		my ($ret, $msg) = $Ticket->AddWatcher(Type => $type, PrincipalId => $Principal);
	if ($ret) {		if ($ret) {
	$RT::Logger->info("$scrip: New $type watcher added to ticket #$Id: $addr (#$Principal)");		$RT::Logger->info("$scrip: New $type watcher added to ticket #$Id: $addr (#$Principal)");
	} else {		} else {
	$RT::Logger->error("$scrip: Failed to add new $type watcher to ticket #$Id: $addr (#$~~Principal) - $msg");~~		$RT::Logger->error("$scrip: Failed to add new $type watcher to ticket #$Id: $addr (#$Princi
	}		}
	}		}
	}		}

	return 1;		return 1;
	</pre>		</pre>

	# vim:ft=perl:		# vim:ft=perl:

	----		----